Re: [PATCH v4 7/9] vfio/migration: Add VFIO migration pre-copy support

[Avihai Horon]

On 30/05/2023 13:17, Cédric Le Goater wrote:
> External email: Use caution opening links or attachments
>
>
> > > > diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events
> > > > index 646e42fd27..548f9488a7 100644
> > > > --- a/hw/vfio/trace-events
> > > > +++ b/hw/vfio/trace-events
> > > > @@ -162,6 +162,8 @@ vfio_save_block(const char *name, int 
> > > > data_size) " (%s) data_size %d"
> > > >   vfio_save_cleanup(const char *name) " (%s)"
> > > >   vfio_save_complete_precopy(const char *name, int ret) " (%s) ret %d"
> > > >   vfio_save_device_config_state(const char *name) " (%s)"
> > > > +vfio_save_iterate(const char *name, uint64_t precopy_init_size, 
> > > > uint64_t precopy_dirty_size) " (%s) precopy initial size 
> > > > 0x%"PRIx64" precopy dirty size 0x%"PRIx64"
> > >
> > > the extra '"' at the end breaks compile. No need to resend just for 
> > > that.
> > > It can be fixed.
> > Oh, strange that it doesn't break when I compile it.
> > Do you have any idea why would  that be?
>
> It generates a -Werror=format= .
>
> Did you configure the build with  --disable-werror  ?

Nope.

configure prints this:
User defined options
    [...]
    werror                          : true