Re: [PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

[Het Gala]

On 30/05/23 1:02 pm, Het Gala wrote:

On 30/05/23 12:28 pm, Markus Armbruster wrote:

Het Gala <het.gala@nutanix.com> writes:

On 25/05/23 11:04 pm, Markus Armbruster wrote:

Het Gala <het.gala@nutanix.com> writes:

This patch introduces well defined MigrateAddress struct and its related child
objects.

The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of
string type. The current migration flow follows double encoding scheme for
fetching migration parameters such as 'uri' and this is not an ideal design.

Motive for intoducing struct level design is to prevent double encoding of QAPI
arguments, as Qemu should be able to directly use the QAPI arguments without
any level of encoding.

Other than that, it looks better than what I proposed. Will change it.

    [...]

+# Since 8.1
+##
+{ 'enum': 'MigrateTransport',
+  'data': ['socket', 'exec', 'rdma'] }
+
+##
+# @MigrateExecCommand:

Documentation of @args is missing.

Ack. Should the naming '@args' be replaced by '@filepath' or @path' or something similar ?

Depends on what @args means.

I guess its [program, arg1, arg2, ...].

You could split off the program:

    'program: 'str',
    'args': [ 'str' ]

Try to write clear documentation for both alternatives.  Such an
exercise tends to lead me to the one I prefer.

Hmm, basically here the @args means, for example ['/bin/bash', args1, args2, ..., <command>], where command -> /some/file/path.

Does it even make sense now to break into 3 different parts ?

	'program': 'str'
	'args': [ 'str' ]
	'command': 'str'

This might probably just need to tewak something in the exec file I guess.

    Markus, Daniel - any comments on this ?
> > > > > + #
> > > > > + # Since 8.1
> > > > > + ##
> > > > >             
> > > > Unwanted indentation.
> > > >           
> > > Not able to see any unwanted indentation here ?
> > >         
> > Looks like it got eaten on the way.  The last three lines of the doc
> > comment are indented:
> >
> >     +##
> >     +# @MigrateExecCommand:
> >     + #
> >     + # Since 8.1
> >     + ##
> >     +{ 'struct': 'MigrateExecCommand',
> >     +   'data': {'args': [ 'str' ] } }
> >       
>

[...]

    Regards,
    Het Gala