qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] configure: rename --enable-pypi to --enable-download, c


From: Thomas Huth
Subject: Re: [PATCH 2/5] configure: rename --enable-pypi to --enable-download, control subprojects too
Date: Tue, 30 May 2023 14:00:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 27/05/2023 11.28, Paolo Bonzini wrote:
The behavior of --{enable,disable}-pypi is similar to that of
-Dwrapmode={default,nodownload} respectively.  In particular,
in both cases a feature needs to be explicitly enabled for the
dependency to be downloaded.

So, use a single option to control both cases.  Now, --enable-slirp
will trigger cloning and building of libslirp if the .pc file
is not found on the machine.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  configure              | 17 +++++++----------
  subprojects/.gitignore |  3 +++
  2 files changed, 10 insertions(+), 10 deletions(-)
  create mode 100644 subprojects/.gitignore

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]