Re: [PATCH 1/5] configure: remove --with-git= option

[Daniel P . Berrangé]

On Tue, May 30, 2023 at 02:03:11PM +0200, Paolo Bonzini wrote:
> On Tue, May 30, 2023 at 1:58 PM Thomas Huth <thuth@redhat.com> wrote:
> > The commit cc84d63a42e31c2a that introduce this switch gave a
> > rationale:
> >
> >      Some users can't run a bare 'git' command, due to need for a 
> > transparent
> >      proxying solution such as 'tsocks'. This adds an argument to configure 
> > to
> >      let users specify such a thing:
> >
> >        ./configure --with-git="tsocks git"
> 
> I see, thanks for the additional information--it makes sense to
> include it in the commit message.
> 
> My impression is that the "smart HTTP" protocol has made this concern
> less important. Smart HTTP was introduced in 2009, but back in 2017
> the git protocol running on port 9418 was still quite common. QEMU
> itself switched from git to https in 2018 with commit a897f22b596b62,
> about a year after --with-git was introduced.

Here is the original thread:

  https://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05005.html

yes it was about 'git://' protocol, and yes, creating a wrapper
script call 'git' was a viable option too.  I just added --with-git
as a convenience.

> > But if the plain "git" command is unusable on their system,
> > they should likely introduce a proper wrapper on their end
> > for this command anyway, so IMHO it's ok if we remove this
> > again. Daniel, what do you think?
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|