Re: [PATCH 1/5] configure: remove --with-git= option

[Daniel P . Berrangé]

On Sat, May 27, 2023 at 11:28:47AM +0200, Paolo Bonzini wrote:
> There is not really any scenario where one would use any other git
> binary than "the first git in the PATH" aka $(command -v git).  In
> fact for example "meson subprojects download" or scripts/checkpatch.pl
> do not obey the GIT environment variable.
> 
> Remove the unnecessary knob, but test for the presence of git in
> the configure and git-submodule.sh scripts.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile                 | 2 +-
>  configure                | 6 ++----
>  meson.build              | 1 -
>  scripts/git-submodule.sh | 8 +++++++-
>  4 files changed, 10 insertions(+), 7 deletions(-)

If you just update the commit message to say we are intentionally
reverting functionality from cc84d63a42e31c2afa884fc78610a65ab8ecc06a
and people should create a wrapper script instead:

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|