Re: [PATCH 0/5] meson: replace submodules with wrap files

[Daniel P . Berrangé]

On Sat, May 27, 2023 at 11:28:46AM +0200, Paolo Bonzini wrote:
> The remaining submodules consist of tests/lcitool/libvirt-ci and the
> firmware in roms/.  The former is only used in very specific cases,
> while the latter is mostly used only as a pointer used to create the QEMU
> tarball.  Unfortunately, git-submodule.sh is still needed for roms/SLOF,
> parts of which are used in the QEMU build process for pc-bios/s390-ccw;
> more on this later in this cover letter.
> 
> I'm not sure what's the best way to proceed for roms/SLOF.  Some
> possibilities, in no particular order, include:
> 
> * doing nothing
> 
> * merging --with-git-submodules with --enable-download, and
>   moving the git-submodule.sh rules from the main Makefile to
>   pc-bios/s390-ccw/ (my favorite option)
> 
> * copying the relevant SLOF files into pc-bios/
> 
> Also, getting into more overengineered territory:
> 
> * same as the second option, but also replace the roms/ submodules
>   with text files, in a format similar to .wrap files; meson uses the
>   standard configparser to read them, so it would not be a lot of
>   code.  The files would be parsed by scripts/make-release and
>   pc-bios/s390-ccw/Makefile.
> 
> * adding support for firmware with a meson build system to
>   configure; turn SLOF into a wrap and roms/SLOF into a symlink
>   for ../pc-bios/s390-ccw/subprojects/SLOF.  I'm mentioning this for
>   completeness but this is not something I would like.  On the other
>   hand it could reuse some (or most?) of the code currently used to
>   generate config-meson.cross, so maybe it isn't that bad...


Is there a reason why SLOF/s390-ccw is handled differently from
the other ROMs ?  ie, why haven't we checked in the pre-built
firmware binaries, such that we don't build SLOF by default ?


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|