Re: [PATCH 0/5] meson: replace submodules with wrap files

[Paolo Bonzini]

On Tue, May 30, 2023 at 2:31 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > * adding support for firmware with a meson build system to
> >   configure; turn SLOF into a wrap and roms/SLOF into a symlink
> >   for ../pc-bios/s390-ccw/subprojects/SLOF.  I'm mentioning this for
> >   completeness but this is not something I would like.  On the other
> >   hand it could reuse some (or most?) of the code currently used to
> >   generate config-meson.cross, so maybe it isn't that bad...
>
> Is there a reason why SLOF/s390-ccw is handled differently from
> the other ROMs ?  ie, why haven't we checked in the pre-built
> firmware binaries, such that we don't build SLOF by default ?

The SLOF ROM is checked in.

s390-ccw is also checked in, but it is a QEMU-specific ROM like, on
x86, linuxboot.bin or multiboot.bin. Therefore it's rebuilt by "make"
and its build system is part of QEMU's.

The relationship between s390-ccw and SLOF is that s390-ccw _reuses_
the network stack of SLOF, and pc-bios/s390-ccw/Makefile does so by
simply looking at sources at $(SOURCE_PATH)../../roms/SLOF.

Paolo

>
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>