Re: [PATCH 3/5] meson: subprojects: replace submodules with wrap files

[Daniel P . Berrangé]

On Tue, May 30, 2023 at 02:51:07PM +0200, Paolo Bonzini wrote:
> On Tue, May 30, 2023 at 2:24 PM Daniel P. Berrangé <berrange@redhat.com> 
> wrote:
> > > +    if test -e "$source_path/.git"; then
> > > +        echo "--disable-download specified but subprojects were not"
> > > +        echo "checked out.  Please download subprojects."
> >
> > Building from tarball will be ok as we bundle everything affected. This
> > errror will hit anyone building from git with --disable-download though.
> 
> Right, just like it hits people doing --with-git-submodule=ignore; but
> you're right that --disable-download is more generic and therefore
> this error is more likely to happen.
> 
> > How should developers/users download the subprojects ? Can we tell them
> > what command is needed ?
> 
> For those that want to use --disable-download, I can include "meson
> subprojects download" in the error message, e.g "Please invoke "meson
> subprojects download" before configuring QEMU, or remove
> --disable-download from the command line."

Ok, that sounds reasonable to add to the message.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|