[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 7/7] hw/cxl/events: Add injection of Memory Module Events
|
From: |
Jonathan Cameron |
|
Subject: |
Re: [PATCH v8 7/7] hw/cxl/events: Add injection of Memory Module Events |
|
Date: |
Tue, 30 May 2023 14:33:18 +0100 |
...
> > +#
> > +# @corrected-persistent-error-count: Total number correctable errors
>
> Total number of correctable errors
Gah. I've now seen these too often so read that a good 5 times before
working out what was wrong!
>
> > +# in persistent memory
> > +#
> > +# Since: 8.1
> > +##
> > +{ 'command': 'cxl-inject-memory-module-event',
> > + 'data': { 'path': 'str', 'log': 'CxlEventLog', 'flags' : 'uint8',
> > + 'type': 'uint8', 'health-status': 'uint8',
> > + 'media-status': 'uint8', 'additional-status': 'uint8',
> > + 'life-used': 'uint8', 'temperature' : 'int16',
> > + 'dirty-shutdown-count': 'uint32',
> > + 'corrected-volatile-error-count': 'uint32',
> > + 'corrected-persistent-error-count': 'uint32'
> > + }}
> > +
> > ##
> > # @cxl-inject-poison:
> > #
>
> Neither these nitpicks nor the one on PATCH 5 calls for a respin.
> Simply fix them in the PR. Thanks!
Thanks but for now Michael Tsirkin is still picking up the CXL focused
series based on patch sets so I'll spin a v9 with this stuff tidied up.
While, not true of this particular set, a lot of the CXL series are still
impacting the generic PCI code and so far Michael has been happy with that
approach.
Jonathan
- [PATCH v8 0/7] QEMU CXL Provide mock CXL events and irq support, Jonathan Cameron, 2023/05/26
- [PATCH v8 1/7] hw/cxl/events: Add event status register, Jonathan Cameron, 2023/05/26
- [PATCH v8 2/7] hw/cxl: Move CXLRetCode definition to cxl_device.h, Jonathan Cameron, 2023/05/26
- [PATCH v8 3/7] hw/cxl/events: Wire up get/clear event mailbox commands, Jonathan Cameron, 2023/05/26
- [PATCH v8 4/7] hw/cxl/events: Add event interrupt support, Jonathan Cameron, 2023/05/26
- [PATCH v8 5/7] hw/cxl/events: Add injection of General Media Events, Jonathan Cameron, 2023/05/26
- [PATCH v8 6/7] hw/cxl/events: Add injection of DRAM events, Jonathan Cameron, 2023/05/26
- [PATCH v8 7/7] hw/cxl/events: Add injection of Memory Module Events, Jonathan Cameron, 2023/05/26