qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/5] Use docker "stable" tag


From: Richard Henderson
Subject: Re: [PATCH v2 2/5] Use docker "stable" tag
Date: Tue, 30 May 2023 10:53:32 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 5/30/23 10:49, Daniel P. Berrangé wrote:
On Tue, May 30, 2023 at 06:39:26PM +0100, Daniel P. Berrangé wrote:
On Mon, May 22, 2023 at 06:41:51PM +0100, Camilla Conte wrote:
Use the same tag in all jobs.

Signed-off-by: Camilla Conte <cconte@redhat.com>
---
  .gitlab-ci.d/container-template.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/container-template.yml 
b/.gitlab-ci.d/container-template.yml
index 519b8a9482..11569dd900 100644
--- a/.gitlab-ci.d/container-template.yml
+++ b/.gitlab-ci.d/container-template.yml
@@ -3,7 +3,7 @@
    image: docker:stable
    stage: containers
    services:
-    - docker:dind
+    - docker:stable-dind

For reasons I don't understand, this change is responsible for all our
failed CI jobs involving Fedora being unable to resolve DNS

AFAICT, the ':stable-dind' and ':stable' tags are no longer even supported.

And I found confirmation of this:

   
https://github.com/docker-library/docker/commit/606c63960a4845af7077721eb3900c706f5d0c5e

"This will remove the "test" and "stable" aliases for whatever
  major release comes after 19.03 (so once the next release comes
  out, "stable" will become a stale alias).

  I'm not 100% sure this is the right answer, but the "stable"
  alias has definitely been a huge source of confusion very
  recently (and it doesn't have much meaning anymore anyways
  given the death of the "edge" channel)."

Excellent, thanks for the sleuthing.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]