[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/27] accel/tcg: Fix check for page writeability in load_atomic16
|
From: |
Richard Henderson |
|
Subject: |
[PULL 02/27] accel/tcg: Fix check for page writeability in load_atomic16_or_exit |
|
Date: |
Tue, 30 May 2023 11:59:24 -0700 |
PAGE_WRITE is current writability, as modified by TB protection;
PAGE_WRITE_ORG is the original page writability.
Fixes: cdfac37be0d ("accel/tcg: Honor atomicity of loads")
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/ldst_atomicity.c.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/ldst_atomicity.c.inc b/accel/tcg/ldst_atomicity.c.inc
index 0f6b3f8ab6..35ce6d6368 100644
--- a/accel/tcg/ldst_atomicity.c.inc
+++ b/accel/tcg/ldst_atomicity.c.inc
@@ -156,7 +156,7 @@ static uint64_t load_atomic8_or_exit(CPUArchState *env,
uintptr_t ra, void *pv)
* another process, because the fallback start_exclusive solution
* provides no protection across processes.
*/
- if (!page_check_range(h2g(pv), 8, PAGE_WRITE)) {
+ if (!page_check_range(h2g(pv), 8, PAGE_WRITE_ORG)) {
uint64_t *p = __builtin_assume_aligned(pv, 8);
return *p;
}
@@ -191,7 +191,7 @@ static Int128 load_atomic16_or_exit(CPUArchState *env,
uintptr_t ra, void *pv)
* another process, because the fallback start_exclusive solution
* provides no protection across processes.
*/
- if (!page_check_range(h2g(p), 16, PAGE_WRITE)) {
+ if (!page_check_range(h2g(p), 16, PAGE_WRITE_ORG)) {
return *p;
}
#endif
--
2.34.1
- [PULL 00/27] tcg patch queue, Richard Henderson, 2023/05/30
- [PULL 01/27] tcg: Fix register move type in tcg_out_ld_helper_ret, Richard Henderson, 2023/05/30
- [PULL 06/27] tcg/aarch64: Rename temporaries, Richard Henderson, 2023/05/30
- [PULL 03/27] meson: Split test for __int128_t type from __int128_t arithmetic, Richard Henderson, 2023/05/30
- [PULL 02/27] accel/tcg: Fix check for page writeability in load_atomic16_or_exit,
Richard Henderson <=
- [PULL 04/27] qemu/atomic128: Add x86_64 atomic128-ldst.h, Richard Henderson, 2023/05/30
- [PULL 14/27] accel/tcg: Add x86_64 load_atom_extract_al16_or_al8, Richard Henderson, 2023/05/30
- [PULL 17/27] tcg: Remove TCG_TARGET_TLB_DISPLACEMENT_BITS, Richard Henderson, 2023/05/30
- [PULL 21/27] decodetree: Do not remove output_file from /dev, Richard Henderson, 2023/05/30
- [PULL 22/27] tests/decode: Convert tests to meson, Richard Henderson, 2023/05/30
- [PULL 24/27] scripts/decodetree: Pass lvalue-formatter function to str_extract(), Richard Henderson, 2023/05/30
- [PULL 13/27] accel/tcg: Extract store_atom_insert_al16 to host header, Richard Henderson, 2023/05/30
- [PULL 18/27] decodetree: Add --test-for-error, Richard Henderson, 2023/05/30
- [PULL 15/27] accel/tcg: Add aarch64 lse2 load_atom_extract_al16_or_al8, Richard Henderson, 2023/05/30
- [PULL 19/27] decodetree: Fix recursion in prop_format and build_tree, Richard Henderson, 2023/05/30