qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices


From: Patrick Venture
Subject: Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices
Date: Wed, 31 May 2023 09:34:42 -0700



On Wed, Mar 22, 2023 at 2:40 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
On 22/3/23 22:19, Corey Minyard wrote:
> On Wed, Mar 22, 2023 at 10:21:36AM -0700, Patrick Venture wrote:
>> This allows the devices to be more readily found and specified.
>> Without setting the name field, they can only be found by device type
>> name, which doesn't let you specify the second of the same device type
>> behind a bus.
>>
>> Tested: Verified that by default the device was findable with the name
>> 'pca954x[77]', for an instance attached at that address.
>
> This looks good to me.
>
> Acked-by: Corey Minyard <cminyard@mvista.com>
>
> if you are taking this in through another tree.  Or do you want me to
> take this?

Since I have to send a MIPS PR, I'll take this one;
to alleviate you and the CI minutes.

I don't see this patch yet, did it got lost in the shuffle?

thanks,
Patrick
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]