[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Prepare bcm properties for videocore 4
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] Prepare bcm properties for videocore 4 |
|
Date: |
Wed, 31 May 2023 17:49:23 +0100 |
On Wed, 31 May 2023 at 16:47, Kambalin, Sergey
<sergey.kambalin@auriga.com> wrote:
>
> Hello!
>
> Thank you guys for clarifications!
>
>
> > Are the VC4 properties supposed to be present on
> > all our existing raspi models? (i.e. is this a bug
> > fix for our existing models rather than stuff we only
> > want on the new raspi4b?)
>
>
> Yes, they're needed to support RPI4 work. And I think cannot be considered as
> a bug fix.
>
> So I'm going to send one patch to replace the magic values with named
> constants.
>
> And then I'm going to spend some time to slice the entire rpi4 machine to
> series of small patches.
>
> Am I understand it right that each patch in the set must pass all the tests?
Yes, that's right -- every patch has to compile and pass
'make check'. The usual way to arrange this is "put the new
tests last".
thanks
-- PMM