Re: [PULL 00/21] Migration 20230530 patches

[Juan Quintela]

Juan Quintela <quintela@redhat.com> wrote:
> Richard Henderson <richard.henderson@linaro.org> wrote:
>> On 5/30/23 11:25, Juan Quintela wrote:
>>> The following changes since commit aa9bbd865502ed517624ab6fe7d4b5d89ca95e43:
>>>    Merge tag 'pull-ppc-20230528' of https://gitlab.com/danielhb/qemu
>>> into staging (2023-05-29 14:31:52 -0700)
>>> are available in the Git repository at:
>>>    https://gitlab.com/juan.quintela/qemu.git
>>> tags/migration-20230530-pull-request
>>> for you to fetch changes up to
>>> c63c544005e6b1375a9c038f0e0fb8dfb8b249f4:
>>>    migration/rdma: Check sooner if we are in postcopy for
>>> save_page() (2023-05-30 19:23:50 +0200)
>>> ----------------------------------------------------------------
>>> Migration 20230530 Pull request (take 2)
>>> Hi
>>> Resend last PULL request, this time it compiles when CONFIG_RDMA is
>>> not configured in.
>>> [take 1]
>>> On this PULL request:
>>> - Set vmstate migration failure right (vladimir)
>>> - Migration QEMUFileHook removal (juan)
>>> - Migration Atomic counters (juan)
>>> Please apply.
>>> ----------------------------------------------------------------
>>> Juan Quintela (16):
>>>    migration: Don't abuse qemu_file transferred for RDMA
>>>    migration/RDMA: It is accounting for zero/normal pages in two places
>>>    migration/rdma: Remove QEMUFile parameter when not used
>>>    migration/rdma: Don't use imaginary transfers
>>>    migration: Remove unused qemu_file_credit_transfer()
>>>    migration/rdma: Simplify the function that saves a page
>>>    migration: Create migrate_rdma()
>>>    migration/rdma: Unfold ram_control_before_iterate()
>>>    migration/rdma: Unfold ram_control_after_iterate()
>>>    migration/rdma: Remove all uses of RAM_CONTROL_HOOK
>>>    migration/rdma: Unfold hook_ram_load()
>>>    migration/rdma: Create rdma_control_save_page()
>>>    qemu-file: Remove QEMUFileHooks
>>>    migration/rdma: Move rdma constants from qemu-file.h to rdma.h
>>>    migration/rdma: Remove qemu_ prefix from exported functions
>>>    migration/rdma: Check sooner if we are in postcopy for save_page()
>>> Vladimir Sementsov-Ogievskiy (5):
>>>    runstate: add runstate_get()
>>>    migration: never fail in global_state_store()
>>>    runstate: drop unused runstate_store()
>>>    migration: switch from .vm_was_running to .vm_old_state
>>>    migration: restore vmstate on migration failure
>>
>> Appears to introduce multiple avocado failures:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/4378066518#L286
>>
>> Test summary:
>> tests/avocado/migration.py:X86_64.test_migration_with_exec: ERROR
>> tests/avocado/migration.py:X86_64.test_migration_with_tcp_localhost: ERROR
>> tests/avocado/migration.py:X86_64.test_migration_with_unix: ERROR
>> make: *** [/builds/qemu-project/qemu/tests/Makefile.include:142: 
>> check-avocado] Error 1
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/4378066523#L387
>>
>> Test summary:
>> tests/avocado/migration.py:X86_64.test_migration_with_tcp_localhost: ERROR
>> tests/avocado/migration.py:X86_64.test_migration_with_unix: ERROR
>> make: *** [/builds/qemu-project/qemu/tests/Makefile.include:142: 
>> check-avocado] Error 1
>>
>> Also fails QTEST_QEMU_BINARY=./qemu-system-aarch64 
>> ./tests/qtest/migration-test
>>
>> ../src/migration/rdma.c:408:QIO_CHANNEL_RDMA: Object 0xaaaaf7bba680 is
>> not an instance of type qio-channel-rdma
>> qemu-system-aarch64: Not a migration stream
>> qemu-system-aarch64: load of migration failed: Invalid argument

And now I am stuck here.  Neither migration-test or avocado test
migration-rdma, so clearly I broke something that don't show on
migration-test but shows on avocado.

Still trying to get avocado to behave on my local test machine.

Later, Juan.


>> Broken pipe
>
> And as it couldn't be anyother way, on my machine (with upstream qemu,
> i.e. none of my changes in):
>
> $ make check-avocado (check-acceptance fails in the same test)
>
> ...
>
> STARTED
>  (063/243) 
> tests/avocado/kvm_xen_guest.py:KVMXenGuest.test_kvm_xen_guest_nomsi: ERROR: 
> ConnectError: Failed to establish session: EOFError\n  Exit code: 1\n  
> Command: ./qemu-system-x86_64 -display none -vga none -chardev 
> socket,id=mon,fd=9 -mon chardev=mon,mode=control -machine q35 -chardev 
> socket,id=console,path=/var/tmp/qemu_yv2aqehm/7f8b6cf5... (2.52 s)
> Interrupting job (failfast).
> RESULTS    : PASS 42 | ERROR 1 | FAIL 0 | SKIP 199 | WARN 0 | INTERRUPT 0 | 
> CANCEL 1
> JOB TIME   : 71.66 s
>
> Test summary:
> tests/avocado/kvm_xen_guest.py:KVMXenGuest.test_kvm_xen_guest_nomsi: ERROR
> make: *** [/mnt/code/qemu/full/tests/Makefile.include:142: check-avocado] 
> Error 9
>
>
> the good news:  Some tests passed.  sixty something.
> the bad news: it is failing on kvm xen guest and I have no clue
>               why/where.
>
> Is there some documentation that can help me here?
>
> Thanks, Juan.