Re: [PULL 01/11] *-user: remove the guest_user_syscall tracepoints

[Richard Henderson]

On 5/31/23 12:48, Stefan Hajnoczi wrote:
> --- a/bsd-user/freebsd/os-syscall.c
> +++ b/bsd-user/freebsd/os-syscall.c
> @@ -531,7 +531,6 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, 
> abi_long arg1,
>       CPUState *cpu = env_cpu(cpu_env);
>       abi_long ret;
>   
> -    trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8);
>       if (do_strace) {
>           print_freebsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6);
>       }
> @@ -541,7 +540,6 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, 
> abi_long arg1,
>       if (do_strace) {
>           print_freebsd_syscall_ret(num, ret);
>       }
> -    trace_guest_user_syscall_ret(cpu, num, ret);
>   
>       return ret;
>   }

Failed to remove the now unused cpu variable:

https://gitlab.com/qemu-project/qemu/-/jobs/4387911615#L6426

../bsd-user/freebsd/os-syscall.c:531:15: error: unused variable 'cpu' 
[-Werror,-Wunused-variable]
    CPUState *cpu = env_cpu(cpu_env);
              ^
1 error generated.


r~