[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v14 02/10] accel/tcg: introduce TBStatistics structure
|
From: |
Wu, Fei |
|
Subject: |
Re: [PATCH v14 02/10] accel/tcg: introduce TBStatistics structure |
|
Date: |
Thu, 1 Jun 2023 11:19:24 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 6/1/2023 8:01 AM, Richard Henderson wrote:
> On 5/30/23 01:35, Fei Wu wrote:
>> +/* TBStatistic collection controls */
>> +enum TBStatsStatus {
>> + TB_STATS_DISABLED = 0,
>> + TB_STATS_RUNNING,
>> + TB_STATS_PAUSED,
>> + TB_STATS_STOPPED
>> +};
>
> I don't see what PAUSED or STOPPED actually do.
> As far as I can see, stats are either being collected or not: a boolean.
>
If STOPPED, clean_tbstats() gets called, all the tbstats history is
destroyed, but it's not for PAUSED.
Thanks,
Fei.
>
> r~
- [PATCH v14 00/10] TCG code quality tracking, Fei Wu, 2023/05/30
- [PATCH v14 03/10] accel: collecting TB execution count, Fei Wu, 2023/05/30
- [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics, Fei Wu, 2023/05/30
- [PATCH v14 06/10] monitor: adding tb_stats hmp command, Fei Wu, 2023/05/30
- [PATCH v14 05/10] debug: add -d tb_stats to control TBStatistics collection:, Fei Wu, 2023/05/30