Re: [RFC PATCH 08/19] HostMem: Add private property to indicate to use kvm gmem

[Xiaoyao Li]

On 8/1/2023 1:22 AM, Markus Armbruster wrote:
> Xiaoyao Li <xiaoyao.li@intel.com> writes:
>
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> >
> > Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>
> [...]
>
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index 7f92ea43e8e1..e0b2044e3d20 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -605,6 +605,9 @@
> >   # @reserve: if true, reserve swap space (or huge pages) if applicable
> >   #     (default: true) (since 6.1)
> >   #
> > +# @private: if true, use KVM gmem private memory
> > +#           (default: false) (since 8.1)
> > +#
>
> Please format like
>
>     # @private: if true, use KVM gmem private memory (default: false)
>     #     (since 8.1)
>
> to blend in with recent commit a937b6aa739 (qapi: Reformat doc comments
> to conform to current conventions).

will do it in next version.

Thanks!
-Xiaoyao

> >   # @size: size of the memory region in bytes
> >   #
> >   # @x-use-canonical-path-for-ramblock-id: if true, the canonical path
> > @@ -631,6 +634,7 @@
> >               '*prealloc-context': 'str',
> >               '*share': 'bool',
> >               '*reserve': 'bool',
> > +            '*private': 'bool',
> >               'size': 'size',
> >               '*x-use-canonical-path-for-ramblock-id': 'bool' } }