[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] Allowing setting and overriding parameters in smb.conf
From: |
Henrik Carlqvist |
Subject: |
Re: [PATCH v1] Allowing setting and overriding parameters in smb.conf |
Date: |
Thu, 3 Aug 2023 02:13:44 +0200 |
On Thu, 3 Aug 2023 01:34:04 +0200
Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Henrik Carlqvist, le jeu. 03 août 2023 01:26:02 +0200, a ecrit:
> > On Thu, 3 Aug 2023 01:13:24 +0200
> > Samuel Thibault <samuel.thibault@gnu.org> wrote:
> >
> > > Henrik Carlqvist, le jeu. 03 août 2023 01:09:09 +0200, a ecrit:
> > > > On Wed, 2 Aug 2023 21:53:56 +0200
> > > > Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > > >
> > > > > Henrik Carlqvist, le mar. 01 aoÃÂût 2023 23:27:25 +0200, a
> > > > > ecrit:
> > > > > > @@ -950,10 +953,11 @@ static int slirp_smb(SlirpState* s, const
> > > > > > char*exported_dir,
> > > > > > "printing = bsd\n"
> > > > > > "disable spoolss = yes\n"
> > > > > > "usershare max shares = 0\n"
> > > > > > - "[qemu]\n"
> > > > > > - "path=%s\n"
> > > > > > "read only=no\n"
> > > > > > "guest ok=yes\n"
> > > > > > + "%s"
> > > > > > + "[qemu]\n"
> > > > > > + "path=%s\n"
> > > > >
> > > > > ?This is moving read only and guest ok to the global section?
> > > >
> > > > Thanks for your quick reply!
> > > >
> > > > Yes, I thought that would be OK because the [qemu] share will inherit
> > > > those settings from the global section. By placing those in the global
> > > > section it is possible to override them with later contradicting
> > > > statements like "read only=yes\n" in the %s before the [qemu] section.
> > >
> > > Ok, it would be useful to mention that in the changelog.
> >
> > Is there a changelog in the repo? Or do you mean that I should mention
> > that in the git commit message?
>
> I mean the latter, yes.
Thanks for your feedback! I will provide a new patch tomorrow.
Best regards Henrik