Re: [PATCH v1 8/8] hw/arm/versal: Connect the CFRAME_REG and CFRAME_BCAST_REG

[Peter Maydell]

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias
<francisco.iglesias@amd.com> wrote:
>
> Connect the Configuration Frame controller (CFRAME_REG) and the
> Configuration Frame broadcast controller (CFRAME_BCAST_REG) to the
> Versal machine.
>
> Signed-off-by: Francisco Iglesias <francisco.iglesias@amd.com>

> +    /* CFRAME REG */
> +    for (i = 0; i < ARRAY_SIZE(s->pmc.cframe); i++) {
> +        char *name = g_strdup_printf("cframe%d", i);
> +
> +        object_initialize_child(OBJECT(s), name, &s->pmc.cframe[i],
> +                                TYPE_XLNX_VERSAL_CFRAME_REG);
[...]

> +        g_free(name);

g_autofree is nicer than this kind of explicit free, I think
(here and below)
> +    }

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM