Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

[Igor Mammedov]

On Tue, 1 Aug 2023 15:38:32 -0400
Stefan Berger <stefanb@linux.ibm.com> wrote:

> On 7/31/23 23:02, Joelle van Dyne wrote:
> > On Mon, Jul 17, 2023 at 6:42 AM Igor Mammedov <imammedo@redhat.com> wrote:  
> >>
> >> On Fri, 14 Jul 2023 13:21:33 -0400
> >> Stefan Berger <stefanb@linux.ibm.com> wrote:
> >>  
> >>> On 7/14/23 03:09, Joelle van Dyne wrote:  
> >>>> This logic is similar to TPM TIS ISA device. Since TPM CRB can only
> >>>> support TPM 2.0 backends, we check for this in realize.
> >>>>
> >>>> Signed-off-by: Joelle van Dyne <j@getutm.app>  
> >>>
> >>> This patch changes the order of in which the ACPI table elements are 
> >>> created but doesn't matter and also doesn't seem to upset ACPI test cases 
> >>> from what I saw:  
> >>
> >> it seems we do have tests for TIS only (which I added when I was 
> >> refactoring it to TYPE_ACPI_DEV_AML_IF)
> >> perhaps add a test for CRB before this patch a follow process described in 
> >> bios-tables-test.c
> >> for updating expected blob  
> > I read the file and looked at the commits for TIS tests but I'm not
> > sure I understand how it works. At what point do I specify that the
> > CRB device should be created for the test?  
> 
> For me it would be a bit of trial an error as well. So here's my best guess:
[...]
> Then you run the tests again then it should create those files with the ACPI 
> data and you copy them
> to their destination (like in ca745d2277496464b54fd832c15c45d0227325bb) and 
> remove the changes from
> tests/qtest/bios-tables-test-allowed-diff.h and that becomes your 3rd patch. 
> Once you run the tests
> again with the 3rd patch there should be no more complaints about ACPI 
> related changes.

ACPI tables update procedure as described bios-tables-test.c looks more or less
reasonable to me (heavily biased view) for someone else to follow. It shouldn't
be 'trial an error'. If something is unclear in the process, lets improve
description (while your mind is still not poisoned by knowledge how it works). 

Here is latest patches that one can use as a model for changing ACPI tables.
45d9d318c8 tests: acpi: x86: whitelist expected blobs
44d975ef34 x86: acpi: workaround Windows not handling name references in 
Package properly
6e510855a9 tests: acpi: x86: update expected blobs

> Since CRB ACPI tests are not enabled right now you can add these patches 
> somewhere in the middle of
> the series or also at the end.
> 
> 
> I hope this helps.
> 
>     Stefan
>