qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] configure: unify case statements for CPU canonicaliza


From: Michael Tokarev
Subject: Re: [PATCH v2 3/3] configure: unify case statements for CPU canonicalization
Date: Tue, 8 Aug 2023 15:42:43 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0

08.08.2023 15:03, Paolo Bonzini wrote:
The CPU model has to be canonicalized to what Meson wants in the cross
file, to what Linux uses for its asm-$ARCH directories, and to what
QEMU uses for its user-mode emulation host/$ARCH directories.  Do
all three in a single case statement, and check that the Linux and
QEMU directories actually exist.

At a small cost in repeated lines, this ensures that there are no hidden
ordering requirements between the case statements.  In particular, commit
89e5b7935e9 ("configure: Fix linux-user host detection for riscv64",
2023-08-06) broke ppc64le because it assigned host_arch based on a
non-canonicalized version of $cpu.

Reported-by: Joel Stanley <joel@jms.id.au>
Fixes: 89e5b7935e9 ("configure: Fix linux-user host detection for riscv64", 
2023-08-06)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  configure | 175 +++++++++++++++++++++++++++++++-----------------------
  1 file changed, 102 insertions(+), 73 deletions(-)

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

A nice cleanup.

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]