[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/9] virtio: Add shared memory capability
From: |
Huang Rui |
Subject: |
Re: [PATCH v4 1/9] virtio: Add shared memory capability |
Date: |
Wed, 9 Aug 2023 15:45:21 +0800 |
On Wed, Aug 09, 2023 at 10:11:00AM +0800, Gurchetan Singh wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow
> defining shared memory regions with sizes and offsets of 2^32 and more.
> Multiple instances of the capability are allowed and distinguished
> by a device-specific 'id'.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com>
> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
> Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
> Tested-by: Alyssa Ross <hi@alyssa.is>
> Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-and-Tested-by: Huang Rui <ray.huang@amd.com>
> ---
> hw/virtio/virtio-pci.c | 18 ++++++++++++++++++
> include/hw/virtio/virtio-pci.h | 4 ++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index edbc0daa18..da8c9ea12d 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1435,6 +1435,24 @@ static int virtio_pci_add_mem_cap(VirtIOPCIProxy
> *proxy,
> return offset;
> }
>
> +int virtio_pci_add_shm_cap(VirtIOPCIProxy *proxy,
> + uint8_t bar, uint64_t offset, uint64_t length,
> + uint8_t id)
> +{
> + struct virtio_pci_cap64 cap = {
> + .cap.cap_len = sizeof cap,
> + .cap.cfg_type = VIRTIO_PCI_CAP_SHARED_MEMORY_CFG,
> + };
> +
> + cap.cap.bar = bar;
> + cap.cap.length = cpu_to_le32(length);
> + cap.length_hi = cpu_to_le32(length >> 32);
> + cap.cap.offset = cpu_to_le32(offset);
> + cap.offset_hi = cpu_to_le32(offset >> 32);
> + cap.cap.id = id;
> + return virtio_pci_add_mem_cap(proxy, &cap.cap);
> +}
> +
> static uint64_t virtio_pci_common_read(void *opaque, hwaddr addr,
> unsigned size)
> {
> diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/virtio-pci.h
> index ab2051b64b..5a3f182f99 100644
> --- a/include/hw/virtio/virtio-pci.h
> +++ b/include/hw/virtio/virtio-pci.h
> @@ -264,4 +264,8 @@ unsigned virtio_pci_optimal_num_queues(unsigned
> fixed_queues);
> void virtio_pci_set_guest_notifier_fd_handler(VirtIODevice *vdev, VirtQueue
> *vq,
> int n, bool assign,
> bool with_irqfd);
> +
> +int virtio_pci_add_shm_cap(VirtIOPCIProxy *proxy, uint8_t bar, uint64_t
> offset,
> + uint64_t length, uint8_t id);
> +
> #endif
> --
> 2.41.0.640.ga95def55d0-goog
>
- [PATCH v4 0/9] gfxstream + rutabaga_gfx, Gurchetan Singh, 2023/08/08
- [PATCH v4 2/9] virtio-gpu: CONTEXT_INIT feature, Gurchetan Singh, 2023/08/08
- [PATCH v4 1/9] virtio: Add shared memory capability, Gurchetan Singh, 2023/08/08
- Re: [PATCH v4 1/9] virtio: Add shared memory capability,
Huang Rui <=
- [PATCH v4 3/9] virtio-gpu: hostmem, Gurchetan Singh, 2023/08/08
- [PATCH v4 4/9] virtio-gpu: blob prep, Gurchetan Singh, 2023/08/08
- [PATCH v4 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options, Gurchetan Singh, 2023/08/08
- [PATCH v4 7/9] gfxstream + rutabaga: meson support, Gurchetan Singh, 2023/08/08
- [PATCH v4 6/9] gfxstream + rutabaga: add initial support for gfxstream, Gurchetan Singh, 2023/08/08
- [PATCH v4 9/9] docs/system: add basic virtio-gpu documentation, Gurchetan Singh, 2023/08/08