Re: [RFC v4 04/11] linux-user: Implement native-bypass option support

[Richard Henderson]

On 8/8/23 07:17, Yeqi Fu wrote:
> +#define native_bypass_enabled() native_lib_path ? true : false

Need parenthesis for the expression, and possibly better as

    (native_lib_path != NULL)

rather than ternary expression.

> +#if defined(CONFIG_NATIVE_CALL)
> +    /* Set the library for native bypass  */
> +    if (native_lib_path) {
> +        if (g_file_test(native_lib_path, G_FILE_TEST_EXISTS)) {

G_FILE_TEST_EXISTS may be a directory.
Better with G_FILE_TEST_IS_REGULAR, I guess?


r~