[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_i
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids() |
|
Date: |
Thu, 10 Aug 2023 09:51:12 +0200 |
On Wed, Aug 09, 2023 at 07:16:00PM -0300, Daniel Henrique Barboza wrote:
> Drew,
>
> On 8/3/23 09:05, Andrew Jones wrote:
> > On Thu, Aug 03, 2023 at 08:36:57AM -0300, Daniel Henrique Barboza wrote:
...
> > So, I think we need a helper that has a switch on the KVM register type
> > and provides the right sized buffer for each case.
>
> Is this a suggestion to do this right now in this patch? I didn't understand
> whether you're ok with the fix as is for 8.1 or if you want more things done
> right away.
>
The fix looks good for 8.1. Using target_ulong looks right to me for all
KVM ULONG-sized registers. When we try to build an API which provides the
right sized buffers (which is future work), we'll want to use target_ulong
there too.
Thanks,
drew
- [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Daniel Henrique Barboza, 2023/08/02
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Andrew Jones, 2023/08/03
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Daniel Henrique Barboza, 2023/08/03
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Andrew Jones, 2023/08/03
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Daniel Henrique Barboza, 2023/08/03
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Daniel Henrique Barboza, 2023/08/09
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(),
Andrew Jones <=
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Alistair Francis, 2023/08/10
- Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Daniel Henrique Barboza, 2023/08/11
Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Andrew Jones, 2023/08/10
Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Alistair Francis, 2023/08/10
Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids(), Alistair Francis, 2023/08/10