Re: [PATCH for-8.1 v10 10/14] util/selfmap: Rewrite using qemu/interval-tree.h

[Helge Deller]

On 8/10/23 23:31, Ilya Leoshkevich wrote:
> On Mon, 2023-08-07 at 11:17 -0700, Richard Henderson wrote:
> > On 8/7/23 09:37, Richard Henderson wrote:
> > > We will want to be able to search the set of mappings.
> > > For this patch, the two users iterate the tree in order.
> > >
> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > > ---
> > >    include/qemu/selfmap.h |  20 ++++----
> > >    linux-user/elfload.c   |  14 +++--
> > >    linux-user/syscall.c   |  15 +++---
> > >    util/selfmap.c         | 114 +++++++++++++++++++++++++-----------
> > > -----
> > >    4 files changed, 96 insertions(+), 67 deletions(-)
> >
> > I should note that, for 8.2, this will enable a rewrite of
> > open_self_maps_1 so that it
> > does not require page-by-page checking of page_get_flags.
> >
> > My idea is that open_self_maps_1 would use walk_memory_regions to see
> > all guest memory
> > regions.  The per-region callback would cross-check with the host-
> > region interval tree to
> > find the dev+inode+path.
> >
> > Cc Ilya and Helge, since there are two outstanding changes to
> > open_self_maps.

I think the rewrite is good.
My patches regarding the map aren't important, I can adjust them
afterwards and resend (if necessary).

Helge