Re: util/async-teardown.c: is it really needed for --disable-system build?

[Michael Tokarev]

14.08.2023 10:27, Claudio Imbrenda wrote:
> On Mon, 14 Aug 2023 10:12:35 +0300
> Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> > 14.08.2023 10:01, Claudio Imbrenda wrote:
> >
> > > I think we could guard the offending item with CONFIG_SOFTMMU for now,
> > > to immediately fix the issues you raised, and do the refactoring you
> > > proposed later (e.g. next cycle).
> >
> > I don't think rushing for the last-minute fix is necessary in this case.
>
> yes and no
>
> it's a bug (which I introduced), and the quick fix seems to be
> easy enough, so why not?

The "quick fix" needs to add guards !USER_ONLY into include file, into
os-posix.c and into async-teardown.c, - that's just too ugly to my taste.
Also, the bug has been here for a very long time, - it is linking the
softmmu/vl.c options parsing part into a common code for qemu-nbd and
qemu-storage-daemon. Your change just discovered it.

No, I don't think this is necessary to apply a quick fix for 8.1.  In
debian I can do that by applying debian-specific patch, and since no one
complained so far, I guess no one else is interested in ia64.

Thanks,

/mjt