Re: [PATCH] migrate/ram: let ram_save_target_page_legacy() return if qemu file got error

[Guoyi Tu]

Thank you for the reminder. There might be some issues with the 
company's email service. I also noticed this morning that I missed 
receiving an email in response from Fabiano.


On 2023/8/17 21:35, 【外部账号】 Peter Xu wrote:
> On Thu, Aug 17, 2023 at 10:19:19AM +0800, Guoyi Tu wrote:
> > On 2023/8/16 23:15, 【外部账号】 Fabiano Rosas wrote:
> > > Peter Xu <peterx@redhat.com> writes:
> > >
> > > > On Tue, Aug 15, 2023 at 07:42:24PM -0300, Fabiano Rosas wrote:
> > > > > Yep, I see that. I meant explicitly move the code into the loop. Feels a
> > > > > bit weird to check the QEMUFile for errors first thing inside the
> > > > > function when nothing around it should have touched the QEMUFile.
> > > >
> > > > Valid point.  This reminded me that now we have one indirection into
> > > > ->ram_save_target_page() which is a hook now.  Putting in the caller will
> > > > work for all hooks, even though they're not yet exist.
> > > >
> > > > But since we don't have any other hooks yet, it'll be the same for now
>
> Guoyi,
>
> Your email got cut from here.  Same thing happened on emails from Hyman
> (also sent from China Telecom email address), maybe your mail system did
> something wrong.