[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 48/58] i386/tdx: Disable SMM for TDX VMs
From: |
Xiaoyao Li |
Subject: |
[PATCH v2 48/58] i386/tdx: Disable SMM for TDX VMs |
Date: |
Fri, 18 Aug 2023 05:50:31 -0400 |
TDX doesn't support SMM and VMM cannot emulate SMM for TDX VMs because
VMM cannot manipulate TDX VM's memory.
Disable SMM for TDX VMs and error out if user requests to enable SMM.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
---
target/i386/kvm/tdx.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
index 7efaa13f59e2..f9d03ab0f461 100644
--- a/target/i386/kvm/tdx.c
+++ b/target/i386/kvm/tdx.c
@@ -678,9 +678,17 @@ static Notifier tdx_machine_done_notify = {
int tdx_kvm_init(MachineState *ms, Error **errp)
{
+ X86MachineState *x86ms = X86_MACHINE(ms);
TdxGuest *tdx = (TdxGuest *)object_dynamic_cast(OBJECT(ms->cgs),
TYPE_TDX_GUEST);
+ if (x86ms->smm == ON_OFF_AUTO_AUTO) {
+ x86ms->smm = ON_OFF_AUTO_OFF;
+ } else if (x86ms->smm == ON_OFF_AUTO_ON) {
+ error_setg(errp, "TDX VM doesn't support SMM");
+ return -EINVAL;
+ }
+
if (!tdx_caps) {
get_tdx_capabilities();
}
--
2.34.1
- [PATCH v2 51/58] i386/tdx: LMCE is not supported for TDX, (continued)
- [PATCH v2 51/58] i386/tdx: LMCE is not supported for TDX, Xiaoyao Li, 2023/08/18
- [PATCH v2 53/58] hw/i386: add option to forcibly report edge trigger in acpi tables, Xiaoyao Li, 2023/08/18
- [PATCH v2 56/58] i386/tdx: Skip kvm_put_apicbase() for TDs, Xiaoyao Li, 2023/08/18
- [PATCH v2 58/58] docs: Add TDX documentation, Xiaoyao Li, 2023/08/18
- [PATCH v2 57/58] i386/tdx: Don't get/put guest state for TDX VMs, Xiaoyao Li, 2023/08/18
- [PATCH v2 40/58] i386/tdx: handle TDG.VP.VMCALL<SetupEventNotifyInterrupt>, Xiaoyao Li, 2023/08/18
- [PATCH v2 45/58] i386/tdx: Limit the range size for MapGPA, Xiaoyao Li, 2023/08/18
- [PATCH v2 50/58] i386/tdx: Don't allow system reset for TDX VMs, Xiaoyao Li, 2023/08/18
- [PATCH v2 38/58] i386/tdx: Call KVM_TDX_INIT_VCPU to initialize TDX vcpu, Xiaoyao Li, 2023/08/18
- [PATCH v2 48/58] i386/tdx: Disable SMM for TDX VMs,
Xiaoyao Li <=
- [PATCH v2 52/58] hw/i386: add eoi_intercept_unsupported member to X86MachineState, Xiaoyao Li, 2023/08/18
- [PATCH v2 55/58] i386/tdx: Only configure MSR_IA32_UCODE_REV in kvm_init_msrs() for TDs, Xiaoyao Li, 2023/08/18
- [PATCH v2 42/58] i386/tdx: register the fd read callback with the main loop to read the quote data, Xiaoyao Li, 2023/08/18
- [PATCH v2 54/58] i386/tdx: Don't synchronize guest tsc for TDs, Xiaoyao Li, 2023/08/18
- Message not available
- Message not available
- Message not available