Re: [PATCH v3 11/18] target/loongarch: Add a check parameter to the TRANS macro

[Philippe Mathieu-Daudé]

On 17/8/23 11:31, Song Gao wrote:
> The default check parmeter is ALL.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   target/loongarch/insn_trans/trans_arith.c.inc |   84 +-
>   .../loongarch/insn_trans/trans_atomic.c.inc   |   80 +-
>   target/loongarch/insn_trans/trans_bit.c.inc   |   56 +-
>   .../loongarch/insn_trans/trans_branch.c.inc   |   20 +-
>   target/loongarch/insn_trans/trans_extra.c.inc |   16 +-
>   .../loongarch/insn_trans/trans_farith.c.inc   |   72 +-
>   target/loongarch/insn_trans/trans_fcnv.c.inc  |   56 +-
>   .../loongarch/insn_trans/trans_fmemory.c.inc  |   32 +-
>   target/loongarch/insn_trans/trans_fmov.c.inc  |   16 +-
>   target/loongarch/insn_trans/trans_lsx.c.inc   | 1322 ++++++++---------
>   .../loongarch/insn_trans/trans_memory.c.inc   |   84 +-
>   .../insn_trans/trans_privileged.c.inc         |   16 +-
>   target/loongarch/insn_trans/trans_shift.c.inc |   30 +-
>   target/loongarch/translate.c                  |    3 +
>   target/loongarch/translate.h                  |    8 +-
>   15 files changed, 951 insertions(+), 944 deletions(-)

Please setup scripts/git.orderfile.

> diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
> index de7c1c5d1f..fd393ed76d 100644
> --- a/target/loongarch/translate.c
> +++ b/target/loongarch/translate.c
> @@ -127,6 +127,9 @@ static void 
> loongarch_tr_init_disas_context(DisasContextBase *dcbase,
>       ctx->va32 = (ctx->base.tb->flags & HW_FLAGS_VA32) != 0;
>   
>       ctx->zero = tcg_constant_tl(0);
> +
> +    ctx->cpucfg1 = env->cpucfg[1];
> +    ctx->cpucfg2 = env->cpucfg[2];

Unrelated to this patch.

>   }

> @@ -35,6 +37,8 @@ typedef struct DisasContext {
>       TCGv zero;
>       bool la64; /* LoongArch64 mode */
>       bool va32; /* 32-bit virtual address */
> +    uint32_t cpucfg1;
> +    uint32_t cpucfg2;

Unrelated to this patch.

>   } DisasContext;

Removing unrelated cpucfgX:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>