Re: [PATCH 2/7] tcg/tcg-op: Document bswap32() byte pattern

[Richard Henderson]

On 8/22/23 02:37, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tcg/tcg-op.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> index f164ddc95e..e6b0d74a46 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -1061,6 +1061,11 @@ void tcg_gen_bswap16_i32(TCGv_i32 ret, TCGv_i32 arg, int 
> flags)
>       }
>   }
>   
> +/*
> + * bswap32_i32: 32-bit byte swap on a 32-bit value.
> + *
> + * Byte pattern:  bswap32_i32(abcd) -> dcba
> + */

Ok.

>   void tcg_gen_bswap32_i32(TCGv_i32 ret, TCGv_i32 arg)
>   {
>       if (TCG_TARGET_HAS_bswap32_i32) {
> @@ -1776,6 +1781,13 @@ void tcg_gen_bswap16_i64(TCGv_i64 ret, TCGv_i64 arg, int 
> flags)
>       }
>   }
>   
> +/*
> + * bswap32_i64: 32-bit byte swap on the low bits of a 64-bit value.
> + *
> + * Byte pattern:  bswap32_i64(xxxxabcd) -> ....dcba     (TCG_BSWAP_OZ)
> + *                bswap32_i64(xxxxabcd) -> ssssdcba     (TCG_BSWAP_OS)
> + *                bswap32_i64(xxxxabcd) -> xxxxdcba
> + */

Again, TCG_BSWAP_IZ.

r~