Re: [PATCH 12/21] block: Mark bdrv_attach_child() GRAPH_WRLOCK

[Stefan Hajnoczi]

On Thu, Aug 17, 2023 at 02:50:11PM +0200, Kevin Wolf wrote:
> Instead of taking the writer lock internally, require callers to already
> hold it when calling bdrv_attach_child_common(). These callers will
> typically already hold the graph lock once the locking work is
> completed, which means that they can't call functions that take it
> internally.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  include/block/block-global-state.h | 14 ++++++++------
>  block.c                            |  7 +++----
>  block/quorum.c                     |  2 ++
>  block/replication.c                |  6 ++++++
>  tests/unit/test-bdrv-drain.c       | 14 ++++++++++++++
>  tests/unit/test-bdrv-graph-mod.c   | 10 ++++++++++
>  6 files changed, 43 insertions(+), 10 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

signature.asc
Description: PGP signature