|
From: | Manos Pitsidianakis |
Subject: | Re: [PATCH v7 10/12] virtio-sound: implement audio output (TX) |
Date: | Wed, 23 Aug 2023 11:42:55 +0300 |
User-agent: | meli 0.7.3 |
Hello Philippe, On Wed, 23 Aug 2023 01:17, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
+ trace_virtio_snd_handle_xfer();Maybe ...
<- snip ->
... it is more useful displaying the callback stream index here? trace_virtio_snd_handle_xfer(hdr.stream_id);
Certainly, why not. This is an extremely noisy trace print by the way, I was not sure whether to keep it or not. Printing it inside the for-loop would potentially make it more noisy.
Would you say this warrants a new patch series version? Otherwise I will include it if other things come up as well.
Manos
[Prev in Thread] | Current Thread | [Next in Thread] |