Re: [PATCH v1 2/7] hw/fsi: Introduce IBM's scratchpad

[Ninad Palsule]

Hello Thomas,

On 8/28/23 20:52, Thomas Huth wrote:
> On 25/08/2023 22.30, Ninad Palsule wrote:
> > This is a part of patchset where IBM's Flexible Service Interface is
> > introduced.
> >
> > The LBUS device is embeded inside the scratchpad. The scratchpad
> > provides a non-functional registers. There is a 1-1 relation between
> > scratchpad and LBUS devices. Each LBUS device has 1K memory mapped in
> > the LBUS.
> >
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> > ---
> >   hw/fsi/Kconfig                     |   4 ++
> >   hw/fsi/engine-scratchpad.c         | 100 +++++++++++++++++++++++++++++
> >   hw/fsi/meson.build                 |   1 +
> >   include/hw/fsi/engine-scratchpad.h |  32 +++++++++
> >   4 files changed, 137 insertions(+)
> >   create mode 100644 hw/fsi/engine-scratchpad.c
> >   create mode 100644 include/hw/fsi/engine-scratchpad.h
> >
> > diff --git a/hw/fsi/Kconfig b/hw/fsi/Kconfig
> > index 687449e14e..2a9c49f2c9 100644
> > --- a/hw/fsi/Kconfig
> > +++ b/hw/fsi/Kconfig
> > @@ -1,2 +1,6 @@
> > +config SCRATCHPAD
> > +    bool
> > +    select LBUS
> > +
> >   config LBUS
> >       bool
>
> The config names sound pretty generic ... could you maybe name them 
> FSI_SCRATCHPAD and FSI_LBUS instead?

OK, I fixed it by adding the FSI prefix.

Thank you for the review.

Ninad

>  Thomas