qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/10] contrib/plugins: use an independent makefile


From: Daniel P . Berrangé
Subject: Re: [PATCH 06/10] contrib/plugins: use an independent makefile
Date: Tue, 29 Aug 2023 18:16:16 +0100
User-agent: Mutt/2.2.9 (2022-11-12)

On Tue, Aug 29, 2023 at 10:29:27AM +0200, Paolo Bonzini wrote:
> The initial reason to write this patch was to remove the last use of
> CONFIG_DEBUG_TCG from the makefiles; the flags to use to build TCG
> plugins are unrelated to --enable-debug-tcg, and instead they should
> be the same as those used to build emulators (the plugins are not build
> via meson for demonstration reasons only).
> 
> However, since contrib/plugins/Makefile is also the last case of doing
> a compilation job using config-host.mak, go a step further and make it
> use a completely separate configuration file, removing all references
> to compilers from the toplevel config-host.mak.  Clean up references to
> empty variables, and use .SECONDARY so that intermediate object files
> are not deleted.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure                | 12 +++++++++---
>  contrib/plugins/Makefile | 18 +++++++++---------
>  2 files changed, 18 insertions(+), 12 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]