Re: [PATCH 09/67] ui/console: get the DisplayState from new_console()

[BALATON Zoltan]

On Wed, 30 Aug 2023, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> There is no obvious reason to defer text console initialization. We can
> simply take the global display state in new_console().
>
> This simplify somewhat the code to allow moving the VC to a separate unit.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/console.c | 26 ++++++++------------------
> 1 file changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/ui/console.c b/ui/console.c
> index fc1836782d..ba79c735b7 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -143,7 +143,7 @@ static QTAILQ_HEAD(, QemuConsole) consoles =
> static bool cursor_visible_phase;
> static QEMUTimer *cursor_timer;
>
> -static void text_console_do_init(Chardev *chr, DisplayState *ds);
> +static void text_console_do_init(Chardev *chr);
> static void dpy_refresh(DisplayState *s);
> static DisplayState *get_alloc_displaystate(void);
> static void text_console_update_cursor_timer(void);
> @@ -1249,9 +1249,10 @@ static void text_console_update(void *opaque, 
> console_ch_t *chardata)
>     }
> }
>
> -static QemuConsole *new_console(DisplayState *ds, console_type_t console_type,
> +static QemuConsole *new_console(console_type_t console_type,
>                                 uint32_t head)

It should be possible to remove the new line and fit it in one line now 
too.

Regards,
BALATON Zoltan