Re: [PATCH 46/67] ui/vc: rename kbd_put → qemu_text_console functions

[Philippe Mathieu-Daudé]

On 30/8/23 11:38, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> They are QemuTextConsole functions, let's make it clear.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   include/ui/console.h |  6 ++---
>   ui/console.c         | 10 ++++----
>   ui/curses.c          |  2 +-
>   ui/gtk.c             |  6 ++---
>   ui/sdl2-input.c      |  4 ++--
>   ui/sdl2.c            |  2 +-
>   ui/vnc.c             | 54 ++++++++++++++++++++++----------------------
>   ui/cocoa.m           |  2 +-
>   8 files changed, 43 insertions(+), 43 deletions(-)
>
> diff --git a/include/ui/console.h b/include/ui/console.h
> index 9c362f0e87..26d63d17a2 100644
> --- a/include/ui/console.h
> +++ b/include/ui/console.h
> @@ -112,9 +112,9 @@ bool qemu_mouse_set(int index, Error **errp);
>   #define QEMU_KEY_CTRL_PAGEUP     0xe406
>   #define QEMU_KEY_CTRL_PAGEDOWN   0xe407
>   
> -void kbd_put_keysym_console(QemuTextConsole *s, int keysym);
> -bool kbd_put_qcode_console(QemuTextConsole *s, int qcode, bool ctrl);
> -void kbd_put_string_console(QemuTextConsole *s, const char *str, int len);
> +void qemu_text_console_put_keysym(QemuTextConsole *s, int keysym);
> +bool qemu_text_console_put_qcode(QemuTextConsole *s, int qcode, bool ctrl);
> +void qemu_text_console_put_string(QemuTextConsole *s, const char *str, int 
> len);


> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 9eb4da7713..8b97319587 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -784,7 +784,7 @@ - (void) handleMonitorInput:(NSEvent *)event
>       }
>   
>       if (keysym) {
> -        kbd_put_keysym_console(NULL, keysym);
> +        qemu_text_console_keysym(NULL, keysym);
>       }
>   }
>   

../../ui/cocoa.m:787:9: error: call to undeclared function 
'qemu_text_console_keysym'; ISO C99 and later do not support implicit 
function declarations [-Wimplicit-function-declaration]
        qemu_text_console_keysym(NULL, keysym);
        ^

I can compile using:

-- >8 --
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 8b97319587..b886db7510 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -784,7 +784,7 @@ - (void) handleMonitorInput:(NSEvent *)event
     }

     if (keysym) {
-        qemu_text_console_keysym(NULL, keysym);
+        qemu_text_console_put_keysym(NULL, keysym);
     }
 }

---