Re: [PATCH v4 17/48] target/loongarch: Implement xvmul/xvmuh/xvmulw{ev/od}

[Richard Henderson]

On 8/30/23 01:48, Song Gao wrote:
> This patch includes:
> - XVMUL.{B/H/W/D};
> - XVMUH.{B/H/W/D}[U];
> - XVMULW{EV/OD}.{H.B/W.H/D.W/Q.D}[U];
> - XVMULW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}.
>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> ---
>   target/loongarch/vec.h                       |  2 +
>   target/loongarch/insns.decode                | 38 +++++++++++++
>   target/loongarch/disas.c                     | 38 +++++++++++++
>   target/loongarch/vec_helper.c                | 57 ++++++++++---------
>   target/loongarch/insn_trans/trans_lasx.c.inc | 42 ++++++++++++++
>   target/loongarch/insn_trans/trans_lsx.c.inc  | 60 ++++++++++----------
>   6 files changed, 180 insertions(+), 57 deletions(-)
>
> diff --git a/target/loongarch/vec.h b/target/loongarch/vec.h
> index cd6f6a72fd..6fc84c8c5a 100644
> --- a/target/loongarch/vec.h
> +++ b/target/loongarch/vec.h
> @@ -60,4 +60,6 @@
>   #define DO_MIN(a, b)    (a < b ? a : b)
>   #define DO_MAX(a, b)    (a > b ? a : b)
>   
> +#define DO_MUL(a, b)    (a * b)
> +

No need to move this.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~