qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND v5 20/26] gdbstub: Remove gdb_has_xml variable


From: Akihiko Odaki
Subject: Re: [PATCH RESEND v5 20/26] gdbstub: Remove gdb_has_xml variable
Date: Thu, 31 Aug 2023 05:24:20 +0900
User-agent: Mozilla Thunderbird

On 2023/08/31 0:02, Alex Bennée wrote:

Akihiko Odaki <akihiko.odaki@daynix.com> writes:

GDB has XML support since 6.7 which was released in 2007.
It's time to remove support for old GDB versions without XML support.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

In principle I'm fine with this but should we not catch GDB's which
don't send qXfer:features:read earlier?


I don't think so. qXfer:features:read was introduced very long ago so practically such a condition should only happen with a failing GDB. There is nothing special for qXfer:features:read that differentiates from many other possible GDB failures that we do not catch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]