Re: [PATCH v4 18/48] target/loongarch: Implement xvmadd/xvmsub/xvmaddw{ev/od}

[Richard Henderson]

On 8/30/23 01:48, Song Gao wrote:
> This patch includes:
> - XVMADD.{B/H/W/D};
> - XVMSUB.{B/H/W/D};
> - XVMADDW{EV/OD}.{H.B/W.H/D.W/Q.D}[U];
> - XVMADDW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}.
>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> ---
>   target/loongarch/vec.h                       |   3 +
>   target/loongarch/insns.decode                |  34 ++++++
>   target/loongarch/disas.c                     |  34 ++++++
>   target/loongarch/vec_helper.c                | 113 ++++++++++---------
>   target/loongarch/insn_trans/trans_lasx.c.inc |  38 +++++++
>   target/loongarch/insn_trans/trans_lsx.c.inc  |  72 ++++++------
>   6 files changed, 203 insertions(+), 91 deletions(-)
>
> diff --git a/target/loongarch/vec.h b/target/loongarch/vec.h
> index 6fc84c8c5a..06c8d7e314 100644
> --- a/target/loongarch/vec.h
> +++ b/target/loongarch/vec.h
> @@ -62,4 +62,7 @@
>   
>   #define DO_MUL(a, b)    (a * b)
>   
> +#define DO_MADD(a, b, c)  (a + b * c)
> +#define DO_MSUB(a, b, c)  (a - b * c)
> +

Aside from this movement,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~