qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] hw/cxl/cxl_device: Replace magic number in CXLError defi


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/4] hw/cxl/cxl_device: Replace magic number in CXLError definition
Date: Mon, 4 Sep 2023 15:46:15 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0

On 4/9/23 15:28, Jonathan Cameron wrote:
From: Fan Ni <fan.ni@samsung.com>

Replace the magic number 32 with CXL_RAS_ERR_HEADER_NUM for better code
readability and maintainability.

Thanks :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Signed-off-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
  include/hw/cxl/cxl_device.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]