[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 0/4] qapi/migration: Dedup migration parameter objects and fix
From: |
Peter Xu |
Subject: |
[PATCH v3 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash |
Date: |
Tue, 5 Sep 2023 12:23:31 -0400 |
v3:
- Collected R-bs
- Patch 2: some reindents, use ARRAY_SIZE (Thomas)
v2:
- Collected R-bs
- Patch 3: convert to use StrOrNull rather than str for the tls_fields
(it contains a lot of changes, I'll skip listing details, but please
refer to the commit message)
Patch 1 fixes the tls-authz crashing when someone specifies "null"
parameter for tls-authz.
Patch 2 added a test case for all three tls-auth parameters specifying
"null" to make sure nothing will crash ever with 'null' passed into it.
Patch 3-4 are the proposed patches to deduplicate the three migration
parameter objects in qapi/migration.json. Note that in this version (patch
3) we used 'str' to replace 'StrOrNull' for tls-* parameters to make then
deduplicate-able.
Please review, thanks.
Peter Xu (4):
migration/qmp: Fix crash on setting tls-authz with null
tests/migration-test: Add a test for null parameter setups
migration/qapi: Replace @MigrateSetParameters with
@MigrationParameters
migration/qapi: Drop @MigrationParameter enum
qapi/migration.json | 370 +--------------------------------
include/hw/qdev-properties.h | 3 +
migration/options.h | 50 +++++
hw/core/qdev-properties.c | 40 ++++
migration/migration-hmp-cmds.c | 23 +-
migration/options.c | 266 ++++++++++--------------
migration/tls.c | 3 +-
tests/qtest/migration-test.c | 22 ++
8 files changed, 247 insertions(+), 530 deletions(-)
--
2.41.0