Re: [PATCH v2 07/22] hw/arm/armv7m: Clean up local variable shadowing

[Peter Maydell]

On Mon, 4 Sept 2023 at 17:13, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Fix:
>
>   hw/arm/armv7m.c: In function ‘armv7m_realize’:
>   hw/arm/armv7m.c:520:27: warning: declaration of ‘sbd’ shadows a previous 
> local [-Wshadow=compatible-local]
>     520 |             SysBusDevice *sbd = SYS_BUS_DEVICE(&s->bitband[i]);
>         |                           ^~~
>   hw/arm/armv7m.c:278:19: note: shadowed declaration is here
>     278 |     SysBusDevice *sbd;
>         |                   ^~~
>        ---
>
>   hw/arm/armsse.c: In function ‘armsse_realize’:
>   hw/arm/armsse.c:1471:27: warning: declaration of ‘mr’ shadows a previous 
> local [-Wshadow=compatible-local]
>    1471 |             MemoryRegion *mr;
>         |                           ^~
>   hw/arm/armsse.c:917:19: note: shadowed declaration is here
>     917 |     MemoryRegion *mr;
>         |                   ^~
>        ---
>
>   hw/arm/armsse.c:1608:22: warning: declaration of ‘dev_splitter’ shadows a 
> previous local [-Wshadow=compatible-local]
>    1608 |         DeviceState *dev_splitter = DEVICE(splitter);
>         |                      ^~~~~~~~~~~~
>   hw/arm/armsse.c:923:18: note: shadowed declaration is here
>     923 |     DeviceState *dev_splitter;
>         |                  ^~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM