[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/11] hw/i386/pc: Use qdev_prop_set_array()
From: |
Kevin Wolf |
Subject: |
[PATCH 02/11] hw/i386/pc: Use qdev_prop_set_array() |
Date: |
Fri, 8 Sep 2023 16:36:53 +0200 |
Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/i386/pc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 54838c0c41..0e84e454cb 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -81,6 +81,7 @@
#include "qapi/error.h"
#include "qapi/qapi-visit-common.h"
#include "qapi/qapi-visit-machine.h"
+#include "qapi/qmp/qlist.h"
#include "qapi/visitor.h"
#include "hw/core/cpu.h"
#include "hw/usb.h"
@@ -1508,9 +1509,10 @@ static void pc_machine_device_pre_plug_cb(HotplugHandler
*hotplug_dev,
char *resv_prop_str = g_strdup_printf("0xfee00000:0xfeefffff:%d",
VIRTIO_IOMMU_RESV_MEM_T_MSI);
- object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp);
- object_property_set_str(OBJECT(dev), "reserved-regions[0]",
- resv_prop_str, errp);
+ QList *reserved_regions = qlist_new();
+ qlist_append_str(reserved_regions, resv_prop_str);
+ qdev_prop_set_array(dev, "reserved-regions", reserved_regions);
+
g_free(resv_prop_str);
}
--
2.41.0
[PATCH 05/11] hw/arm/sbsa-ref: Use qdev_prop_set_array(), Kevin Wolf, 2023/09/08
[PATCH 04/11] hw/arm/mps2: Use qdev_prop_set_array(), Kevin Wolf, 2023/09/08
[PATCH 06/11] hw/arm/vexpress: Use qdev_prop_set_array(), Kevin Wolf, 2023/09/08