|
| From: | Michael Tokarev |
| Subject: | Re: [PATCH v2] hw/i386/pc: fix code comment on cumulative flash size |
| Date: | Tue, 12 Sep 2023 20:30:48 +0300 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 |
12.09.2023 18:55, Laszlo Ersek:
- The comment is incorrectly indented / formatted.
- The comment states a 8MB limit, even though the code enforces a 16MB
limit.
Both of these warts come from commit 0657c657eb37 ("hw/i386/pc: add max
combined fw size as machine configuration option", 2020-12-09); clean them
up.
Arguably, it's also better to be consistent with the binary units (such as
"MiB") that QEMU uses nowadays.
Applied to my trivial-patches tree. Thanks! /mjt
| [Prev in Thread] | Current Thread | [Next in Thread] |