|
From: | Richard Henderson |
Subject: | Re: [PATCH 05/11] accel/tcg: Modifies memory access functions to use CPUState |
Date: | Tue, 12 Sep 2023 12:34:06 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 |
On 9/12/23 08:34, Anton Johansson wrote:
do_[ld|st]*() and mmu_lookup*() are changed to use CPUState over CPUArchState, moving the target-dependence to the target-facing facing cpu_[ld|st] functions. Signed-off-by: Anton Johansson <anjo@rev.ng> --- accel/tcg/cputlb.c | 324 ++++++++++++++++++++++----------------------- 1 file changed, 161 insertions(+), 163 deletions(-)
So... what's your ultimate plan here?At the moment through patches 5-11, all you do is take CPUArchState, discard knowledge of it via CPUState, and then recover knowledge of it via cpu->tlb_ptr.
I agree that *something* has to happen in order to allow these entry points to be used by multiple cpu types simultaneously, but there must be a plan.
Is it to have tcg generated code perform env_cpu() inline before the call? That's just pointer arithmetic, so it's certainly an easy option.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |