[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/11] accel/tcg: Restrict dump_exec_info() declaration
From: |
Anton Johansson |
Subject: |
Re: [PATCH 03/11] accel/tcg: Restrict dump_exec_info() declaration |
Date: |
Fri, 15 Sep 2023 15:56:01 +0200 |
On 14/09/23, Philippe Mathieu-Daudé wrote:
> In commit 00c9a5c2c3 ("accel/tcg: Restrict 'qapi-commands-machine.h'
> to system emulation") we moved the definition to accel/tcg/ which is
> where this function is called. No need to expose it outside.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/tcg/internal.h | 2 ++
> include/exec/cpu-all.h | 5 -----
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/accel/tcg/internal.h b/accel/tcg/internal.h
> index e8cbbde581..cd6b9eb7f0 100644
> --- a/accel/tcg/internal.h
> +++ b/accel/tcg/internal.h
> @@ -102,6 +102,8 @@ static inline bool cpu_in_serial_context(CPUState *cs)
> extern int64_t max_delay;
> extern int64_t max_advance;
>
> +void dump_exec_info(GString *buf);
> +
> extern bool one_insn_per_tb;
>
> /**
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> index 71efc2d404..221ada2b6d 100644
> --- a/include/exec/cpu-all.h
> +++ b/include/exec/cpu-all.h
> @@ -406,11 +406,6 @@ static inline bool tlb_hit(uint64_t tlb_addr, vaddr addr)
> return tlb_hit_page(tlb_addr, addr & TARGET_PAGE_MASK);
> }
>
> -#ifdef CONFIG_TCG
> -/* accel/tcg/translate-all.c */
> -void dump_exec_info(GString *buf);
> -#endif /* CONFIG_TCG */
> -
> #endif /* !CONFIG_USER_ONLY */
>
> /* accel/tcg/cpu-exec.c */
> --
> 2.41.0
>
Reviewed-by: Anton Johansson <anjo@rev.ng>
- [PATCH 00/11] accel/tcg: Make more files target agnostic (& exec/ housekeeping), Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 01/11] exec: Make EXCP_FOO definitions target agnostic, Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 02/11] exec: Move cpu_loop_foo() target agnostic functions to 'cpu-common.h', Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 03/11] accel/tcg: Restrict dump_exec_info() declaration, Philippe Mathieu-Daudé, 2023/09/14
- Re: [PATCH 03/11] accel/tcg: Restrict dump_exec_info() declaration,
Anton Johansson <=
- [PATCH 04/11] accel: Make accel-blocker.o target agnostic, Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 05/11] accel: Rename accel-common.c -> accel-target.c, Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 06/11] exec: Rename cpu.c -> cpu-target.c, Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 07/11] exec: Rename target specific page-vary.c -> page-vary-target.c, Philippe Mathieu-Daudé, 2023/09/14
- [PATCH 08/11] accel/tcg: Rename target-specific 'internal.h' -> 'internal-target.h', Philippe Mathieu-Daudé, 2023/09/14