|
From: | Helge Deller |
Subject: | Re: [PATCH v4 00/10] linux-user: Detect and report host crashes |
Date: | Mon, 18 Sep 2023 16:05:34 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 9/12/23 12:34, Michael Tokarev wrote:
12.09.2023 12:45, Helge Deller:/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/13/../../../../lib64/libc.a(abort.o): in function `abort': (.text.unlikely+0x0): multiple definition of `abort'; libqemu-aarch64-linux-user.fa.p/linux-user_signal.c.o:/srv/_build/../../home/cvs/qemu/qemu/linux-user/signal.c:723: first defined here[PATCH v4 03/10] linux-user: Use die_with_signal with abort Sigh. I'd be double-cautious when overriding system functions like this, - it's almost always a bad idea.
Richard, I'm not sure, but with that change: -void abort(void) +void __attribute__((weak)) abort(void) it will at least successfully link the binary. Not sure which effects it has, but probably not worse than before your patch series... Helge
[Prev in Thread] | Current Thread | [Next in Thread] |