[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nod
From: |
Ankit Agrawal |
Subject: |
RE: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes |
Date: |
Fri, 22 Sep 2023 05:49:46 +0000 |
Hi Jonathan
> > + if (pcidev->pdev.has_coherent_memory) {
> > + uint64_t start_node = object_property_get_uint(obj,
> > + "dev_mem_pxm_start", &error_abort);
> > + uint64_t node_count = object_property_get_uint(obj,
> > + "dev_mem_pxm_count", &error_abort);
> > + uint64_t node_index;
> > +
> > + /*
> > + * Add the node_count PXM domains starting from start_node as
> > + * hot pluggable. The VM kernel parse the PXM domains and
> > + * creates NUMA nodes.
> > + */
> > + for (node_index = 0; node_index < node_count; node_index++)
> > + build_srat_memory(table_data, 0, 0, start_node +
> > node_index,
> > + MEM_AFFINITY_ENABLED |
> > + MEM_AFFINITY_HOTPLUGGABLE);
>
> 0 size SRAT entries for memory? That's not valid.
Can you explain in what sense are these invalid? The Linux kernel accepts
such setting and I had tested it.
> Seems like you've run into the same issue CXL has with dynamic addition of
> nodes to the kernel and all you want to do here is make sure it thinks there
> are
> enough nodes so initializes various structures large enough.
>
Yes, exactly.
- [PATCH v1 0/4] vfio: report NUMA nodes for device memory, ankita, 2023/09/14
- [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, ankita, 2023/09/14
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jonathan Cameron, 2023/09/15
- RE: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes,
Ankit Agrawal <=
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jonathan Cameron, 2023/09/25
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jason Gunthorpe, 2023/09/25
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jonathan Cameron, 2023/09/25
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jason Gunthorpe, 2023/09/25
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jonathan Cameron, 2023/09/25
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Ankit Agrawal, 2023/09/26
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Ankit Agrawal, 2023/09/27
- Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Jonathan Cameron, 2023/09/27
Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes, Igor Mammedov, 2023/09/15