[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/8] migration fixes
From: |
Peter Xu |
Subject: |
Re: [PATCH 0/8] migration fixes |
Date: |
Wed, 27 Sep 2023 09:58:10 -0400 |
On Wed, Sep 27, 2023 at 09:39:33AM -0300, Fabiano Rosas wrote:
> Fabiano Rosas <farosas@suse.de> writes:
>
> > This series contains fixes for the two currently know failures that
> > show up in migration tests plus a set of fixes for some theoretical
> > race conditions around QEMUFile handling.
> >
> > Patch 1 addresses the issue found in the postcopy/preempt/plain test:
> > https://gitlab.com/qemu-project/qemu/-/issues/1886
> >
> > Patch 7 fixes a rare crash during the postocpy/preempt/recovery/plain test:
> >
> > Thread 7 "return path" received signal SIGSEGV, Segmentation fault.
> > 0x00005555560e4893 in qemu_file_get_error_obj (f=0x0, errp=0x0) at
> > ../migration/qemu-file.c:154
> > 154 return f->last_error;
> >
> > CI run: https://gitlab.com/farosas/qemu/-/pipelines/1008652837
> >
> > Fabiano Rosas (7):
> > migration: Fix possible race when setting rp_state.error
> > migration: Fix possible races when shutting down the return path
> > migration: Fix possible race when shutting down to_dst_file
> > migration: Remove redundant cleanup of postcopy_qemufile_src
> > migration: Consolidate return path closing code
> > migration: Replace the return path retry logic
> > migration: Move return path cleanup to main migration thread
> >
> > Peter Xu (1):
> > migration: Fix race that dest preempt thread close too early
> >
> > migration/migration.c | 145 +++++++++++++++------------------------
> > migration/migration.h | 14 +++-
> > migration/postcopy-ram.c | 38 +++++++++-
> > 3 files changed, 106 insertions(+), 91 deletions(-)
>
> Ping
Stefan,
This is the series I mentioned to you before that will solve all known
migration-test intermittent failures. It covers two bugs we're aware of.
I've already provided all R-bs on the patches.
Feel free to merge this series if you want even before Juan's back.
Thanks!
--
Peter Xu
- [PATCH 0/8] migration fixes, Fabiano Rosas, 2023/09/18
- [PATCH 1/8] migration: Fix race that dest preempt thread close too early, Fabiano Rosas, 2023/09/18
- [PATCH 4/8] migration: Fix possible race when shutting down to_dst_file, Fabiano Rosas, 2023/09/18
- [PATCH 2/8] migration: Fix possible race when setting rp_state.error, Fabiano Rosas, 2023/09/18
- [PATCH 3/8] migration: Fix possible races when shutting down the return path, Fabiano Rosas, 2023/09/18
- [PATCH 5/8] migration: Remove redundant cleanup of postcopy_qemufile_src, Fabiano Rosas, 2023/09/18
- [PATCH 6/8] migration: Consolidate return path closing code, Fabiano Rosas, 2023/09/18
- [PATCH 7/8] migration: Replace the return path retry logic, Fabiano Rosas, 2023/09/18
- [PATCH 8/8] migration: Move return path cleanup to main migration thread, Fabiano Rosas, 2023/09/18
- Re: [PATCH 0/8] migration fixes, Fabiano Rosas, 2023/09/27
- Re: [PATCH 0/8] migration fixes,
Peter Xu <=
- Re: [PATCH 0/8] migration fixes, Stefan Hajnoczi, 2023/09/27
- Re: [PATCH 0/8] migration fixes, Stefan Hajnoczi, 2023/09/27