Re: [PATCH 7/8] target/sparc: Fix VIS fexpand input register.

[Richard Henderson]

On 9/24/23 01:03, Nick Bowler wrote:
> This instruction is documented to get its input from the second
> single-precision input operand; the first operand is ignored.
> This is exactly what a real UltraSparc II does.  Meanwhile, the
> the emulator uses only the irrelevant first operand, treating
> it as a double-precision register, and ignores the second.
>
> This will not normally contain the correct data so the emulated
> instruction usually just produces garbage.
>
> Signed-off-by: Nick Bowler<nbowler@draconx.ca>
> ---
>   target/sparc/helper.h     | 2 +-
>   target/sparc/translate.c  | 5 ++++-
>   target/sparc/vis_helper.c | 5 ++---
>   3 files changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~